otclient icon indicating copy to clipboard operation
otclient copied to clipboard

Fixed items minimap color and battle square

Open erexo opened this issue 7 years ago • 4 comments

Some items marked as "common" are actually an important terrain items (like doors/fences/street lamps and so on). It makes minimap much more readable if every item with minimap color is shown (as in Cip client).

erexo avatar Aug 28 '17 21:08 erexo

Known bug; Since there is one opcode from server that tells to stop both attacking and following, when player is following a creature and decide to attack other, the client will remove attacked crature and add followed, trigger event that we are not attacking anything now so server send us back this cancel opcode so client cancel the follow and we end up with nothing. Cip client somehow managed to pass through it

erexo avatar Sep 27 '17 22:09 erexo

so this passed or not?

Felipe1993 avatar Oct 10 '17 16:10 Felipe1993

Instead of deleting the if statement you should have checked for the specified items. If this is merged we will have to iterate through every item to draw it on map, which would be very bad. Also you should make different branches for different commits instead of just make one pull request with lots of commits. As for the bug of attacking who you are following, I'll test it to confirm

andersonfaaria avatar Nov 17 '17 18:11 andersonfaaria

Any updates?

pasturryx avatar Jan 28 '20 02:01 pasturryx