otclient icon indicating copy to clipboard operation
otclient copied to clipboard

Published 20 hours ago • verified publisher icon edubart

game_store module

Open metabobb opened this issue 5 years ago • 5 comments

Changes to game_market:

  • game_market ui/ux improvements
  • added server opcode support 238
  • added client opcode support 233

Changes to compiling on linux:

  • fixes compile errors on linux (kernel: 4.15.0-47-generic). Tested on Ubuntu 18.04

New game module:

  • game_store module

metabobb avatar Apr 15 '19 14:04 metabobb

Note Travis build fails with g++: error: unrecognized command line option ‘-no-pie’. Could be due to compiler version mismatch. Travis uses gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4 while I tested on gcc (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0.

Edit: tested again on gcc version 7.3.0 (Ubuntu 7.3.0-27ubuntu1~18.04) and build completes with no errors.

metabobb avatar Apr 15 '19 14:04 metabobb

@metabobb Most of your code seems fine, however there are major code style issues. Also, there's a lot of different stuff on a single PR.

hrsantiago avatar Apr 15 '19 23:04 hrsantiago

@hrsantiago Review the code if you want and I'll make the necessary changes. You can also create a pull request on my repo to fix whatever issues there might be.

Also, sorry that it's so much stuff. With regards to game_market I have added a minor UI/UX change and made the client update market data automatically wherever possible (as far as bot protection allowed). Other commits seem self-explanatory to me.

I've made a thread on OTLand showcasing the module and explaining how to test: https://otland.net/threads/release-game_store-module.264142/

metabobb avatar Apr 16 '19 12:04 metabobb

Thanks @metabobb it solve my problem, this: https://otland.net/threads/otc-market-bug-and-mounts-bug.264163/#post-2552817

Thank you very much ... I tried to fix this mistake for days, and apparently I would never get it, since I was looking in a totally wrong direction. Its modifications in the market and protocol have totally solved. Now the market opens without any problems. I will test the other things and give my report, for now I have only to thank and I hope that more people like you appear in the Tibian community.

dudantas avatar Apr 17 '19 03:04 dudantas

@eduardodantas95 Yes, I have fixed that and also added support for two missing opcodes for client & server. I have tested the market with these changes and it run normally without any issues.

metabobb avatar Apr 17 '19 12:04 metabobb