include-media icon indicating copy to clipboard operation
include-media copied to clipboard

Feature/add conatiner queries

Open jackmcpickle opened this issue 1 year ago • 3 comments

Addresses https://github.com/eduardoboucas/include-media/issues/223 by adding container mixin

Currently some issue with sass-true and container mixin. Maybe a bug?

jackmcpickle avatar Feb 27 '23 11:02 jackmcpickle

@andreimoment Review?

jackmcpickle avatar Feb 27 '23 11:02 jackmcpickle

@jackmcpickle thank you for submitting these. I noticed a few things:

  • I couldn't run the tests - adding @container to the tests results in errors - I see you've commented out that line.
  • When the @container tests run OK, I recommend:
    • adding tests using the new container units
    • adding a test for the "named: " parameter
  • I did not see any additions pertaining to the "named: ..." parameter.

Note, I am not a maintainer for this - just someone who suggested adding the feature. I apologize for not acting on this sooner - SCSS is not my forte and it will take me a bit of time to understand all of the code and propose an update.

Thank you for acting swiftly and moving this in the right direction.

andreimoment avatar Mar 01 '23 00:03 andreimoment

@andreimoment all good. I thought I'd just start with the unnamed @container queries for now.

jackmcpickle avatar Mar 01 '23 03:03 jackmcpickle