compat-report icon indicating copy to clipboard operation
compat-report copied to clipboard

Published 20 hours ago • verified publisher icon eduardoboucas

Icon hardly visible with DevTools's dark theme

Open RiZKiT opened this issue 6 years ago • 3 comments

The icon in the DevTools tab bar does not support the dark theme. I'm unable to find the dark theme css class (?), otherwise I would have submitted a pull request.

screenshot at 2018-02-08 15 38 19

p.s.: And how about i18n support at last for the tab name?

RiZKiT avatar Feb 08 '18 14:02 RiZKiT

I'm afraid it doesn't have any support for themes yet. I'll leave it open in case someone has a chance to look, otherwise I'll get to it as soon as I can. Thanks!

eduardoboucas avatar Feb 09 '18 10:02 eduardoboucas

Thanks for writing this add-on @eduardoboucas!

What some add-ons do is use a greyish color #e6e6e6 that should work in both light and dark theme. Now that I'm thinking about it, I wonder if that was only for browserAction/pageAction buttons :thinking:

Worth a try?

mozfreddyb avatar Mar 15 '18 11:03 mozfreddyb

Definitely worth a try, thanks @mozfreddyb!

I'm expecting to have some time over the next few days to dedicate to this add-on, so I should be able to address this. 🤞

eduardoboucas avatar Mar 15 '18 11:03 eduardoboucas