compat-report icon indicating copy to clipboard operation
compat-report copied to clipboard

Add more browsers to the overview

Open lefta opened this issue 6 years ago • 2 comments

This PR adds almost all browsers to the overview (except NodeJS, this is useless for CSS). It relies on the up to date dataset from #15, some browsers are not in the current dataset.

By the way, the new dataset have a browsers.xxx.name field, so I made use of it to get browser names automatically. This avoids the mess of having to maintain it manually. Please let me know if you don't agree with it, I will drop this change :smiley:

Note that some of the new browsers are not fully documented in the new dataset. I expect MDN to fill it over the time, but for now it wrongly reports a lot of features as unsupported. Maybe should we put a warning in the readme about that ?

EDIT: BTW, this breaks the "all columns of the same width" stuff as the overview is ways larger now. This is just a visual artifact so I did not manage to fix it for now, I don't even know what would be the best way. ( Horizontal scrolling ? Using icons like on MDN to lower the columns width ? Or anything else ? )

lefta avatar Jun 03 '18 11:06 lefta

This looks great, thank you!

Regarding the column width, I don't know what the best solution is. Do you think we should figure that out first before merging this PR, or not necessarily?

Thanks.

eduardoboucas avatar Jun 05 '18 10:06 eduardoboucas

You're welcome ;)

I don't think the column width is a problem, this is more a small visual artifact rather than a real anoyance. At least, it did not break the UX for me. IMO, you can merge this PR as is. Once done, I will open a ticket to see with you what the best way to handle it would be (which is very subjective BTW...).

lefta avatar Jun 05 '18 11:06 lefta