edrlab
macOS: Activate localization for Thorium Reader's macOS-specific Finder menu
This is a more or less cosmetic issue, but on the other hand, a homogeneous, complete localization very much adds to an 'OS-native' user experience of an application. So I would like to report that Thorium Reader's macOS-specific Finder menu is apparently not yet included in its localization.
By 'its Finder menu' I refer to the Mac-specific, first menu item and its sub-entries in the macOS Finder bar on top of the screen right to the Apple icon, which for macOS applications is always the application's name.
To better illustrate that, here's a screenshot of Thorium Reader 3.1.0 on a German macOS locale:
I'm more than willing to contribute to Thorium Reader's localization, but from my experiences with the frameworks used by other applications (digiKam, OpenTodoList) my uneducated guess is that it might rather be a not yet activated setting in the underlying frameworks here?
Apologies for the late reply!
This should work ... can you please confirm that the bug exists with the most recent build? What official release version are you testing with?
https://github.com/edrlab/thorium-reader/blob/22680d6633ae05e85447569ac261702c49d58307/src/main/menu.ts#L207-L247
https://github.com/edrlab/thorium-reader/blob/22680d6633ae05e85447569ac261702c49d58307/src/resources/locales/de.json#L19-L28
@danielweck Thank you for your reply! My screenshot above was made with Thorium v3.1.0 and I'm currently using Thorium v3.2.2 which shows the same behaviour as above. My macOS version is macOS Sequoia 15.7.1 on Intel, German system locale.