thorium-reader icon indicating copy to clipboard operation
thorium-reader copied to clipboard

"Clear login data" button pressing on my Mac does something strange

Open geometer opened this issue 8 months ago • 5 comments

When I click the button, it becomes blue (it seems like this means "pressed"), and an empty message appears in the bottom left corner. In the screenshot, I pressed the button four times and got four message bubbles. I suspect (but am not sure) it does not clear the data.

Mac on M1 Silicon, MacOS 15.3.1 (24D70). Thorium v3.1.0 (it suggests upgrading to 3.1.1, but I only find the 3.1.0 package by the link).

Image

geometer avatar Apr 30 '25 14:04 geometer

The "thumbs up" emoji means that the data is cleared. The data is cookie jar and access tokens that were set during authenticated HTTP requests (typically, OPDS). The stored LCP passphrases are not cleared.

danielweck avatar Apr 30 '25 15:04 danielweck

it suggests upgrading to 3.1.1, but I only find the 3.1.0 package by the link

Sorry about the confusion, next time we need to release a patch for a platform we will have to rethink the update mechanics.

danielweck avatar Apr 30 '25 15:04 danielweck

The "thumbs up" emoji means that the data is cleared. The data is cookie jar and access tokens that were set during authenticated HTTP requests (typically, OPDS). The stored LCP passphrases are not cleared.

Is there a way to verify that the data is cleared? It looks like all the authorised catalogues continue to be authorised.

geometer avatar Apr 30 '25 16:04 geometer

Update: I can confirm that it clears the data, at least for our test catalogue. So the ticket only makes sense as a minor UI issue.

geometer avatar Apr 30 '25 19:04 geometer

we need to improve the UX of login in/out of OPDS feeds, selectively (not just everything at once). we don't need to go as far as checking that an access token is revoked / needing refresh, as this is usually transparent to the user anyway. but at least offer the possibility of clearing data for specific domains / origins.

danielweck avatar May 01 '25 03:05 danielweck