thorium-reader icon indicating copy to clipboard operation
thorium-reader copied to clipboard

Double click to open a EPUB on Windows?

Open seaspeak opened this issue 1 year ago • 14 comments

Windows or Store version Thorium.Setup.2.4.1 won't open the clicked EPUB. I am always using Thorium.Setup.2.3.0-alpha.1.3658607447.exe, It is the only version I konw, could open the double-clicked EPUB.

seaspeak avatar May 11 '24 01:05 seaspeak

Isn't a registry issue ? could you clear your registry epub file association, to let the window store make the association again. I'm on mac, not a windows user

panaC avatar May 14 '24 14:05 panaC

Not an association problem, I guess. 2.4.1 brings up the main window (as below) and even not import the book/epub and not open the epub.

image

seaspeak avatar May 14 '24 14:05 seaspeak

You cannot import an epub and open it in Thorium 2.4.1 at all ?

panaC avatar May 14 '24 14:05 panaC

If I double-click a new epub, version Thorium.2.3.0-alpha.1.3658607447 will import the new epub and open it in a seperated window. But 2.4 just open the main window, and doesn't even import the new epub.

And yes, I can import a new epub by drag&drop or add in the main window.

seaspeak avatar May 14 '24 14:05 seaspeak

Ok i will check on my side

panaC avatar May 14 '24 15:05 panaC

We will not be able to debug/troubleshoot this from Thorium APPX deployed to the Microsoft Windows Store, but hopefully we will be able to reproduce with the NSIS executable which installs Thorium for either all users or the current local one (i cannot remember what the Electron Builder does)

danielweck avatar May 14 '24 16:05 danielweck

It works on my windows 11 pro machine. I remove by security any application associated with epub file association in Registry Editor. I tested both with a local Thorium build npm run prepackage:win && npm run package:win and Official Github Release 2.4.1 (https://github.com/edrlab/thorium-reader/releases/download/v2.4.1/Thorium.Setup.2.4.1.exe)

File association (double click, or open with) works with Thorium already open or not.

I should be abble to reproduce to help you. I keep the issue open

panaC avatar May 16 '24 09:05 panaC

Thank you for testing @panaC You don't have to manually invoke the "pre" (or "post") build scripts, they are automatically resolved by NPM when calling npm run package:win

danielweck avatar May 16 '24 09:05 danielweck

So could the problem experienced by some users be limited to the Windows Store version? Or maybe the NSIS executable installer is affected when users install the Windows Store version in parallel too?

danielweck avatar May 16 '24 09:05 danielweck

I should be abble to reproduce to help you. I keep the issue open

I am sorry, I am confused. Can you reproduce the problem or you don't have the problem on your site?

I tested the Official Github Release 2.4.1 in Windows 10 Sandbox, so that I don't have to worry about cleaning the registry or user folders. I got the same result.

https://github.com/edrlab/thorium-reader/assets/8821870/5aa9371f-7b0a-4ef8-a8cc-908477b8b62c

seaspeak avatar May 16 '24 10:05 seaspeak

just out of interest, are you able to test with Windows 11?

danielweck avatar May 16 '24 11:05 danielweck

Just tested on my colleague's notebook running Windows 11. It works. I tested release 2.4.1 on Windows 10 Sandbox and a fresh virtual machine, all are not working. So I may be 'confident' to say it is really not working on Window 10. Am I really the only one still using Windows 10? Why isn't anyone feedback this question?

seaspeak avatar May 16 '24 13:05 seaspeak

Surely a breaking change with Electron, sorry !

panaC avatar May 16 '24 13:05 panaC

Thorium, just like other apps built with Electron, doesn't control at a low-level how file associations are created. I guess Electron Builder broke some Windows 10 backward compatibility ... or maybe the NSIS installer which probably is responsible for configuring the registry.

danielweck avatar May 16 '24 15:05 danielweck

I think it's a duplicate with https://github.com/edrlab/thorium-reader/issues/2693 I'm closing the issue for the moment, feel free to reopen it.

panaC avatar Dec 30 '24 14:12 panaC