thorium-reader icon indicating copy to clipboard operation
thorium-reader copied to clipboard

keyboard tab cycling gets stuck in the upper left corner when reverse tabbing (SHIFT TAB)

Open danielweck opened this issue 1 year ago • 4 comments

Screenshot 2024-05-06 at 18 31 22

danielweck avatar May 06 '24 17:05 danielweck

Screenshot 2024-05-06 at 18 33 49

danielweck avatar May 06 '24 17:05 danielweck

https://github.com/radix-ui/primitives/blob/b32a93318cdfce383c2eec095710d35ffbd33a1c/packages/react/dialog/src/Dialog.tsx#L397C11-L397C15

https://github.com/radix-ui/primitives/blob/b32a93318cdfce383c2eec095710d35ffbd33a1c/packages/react/focus-scope/src/FocusScope.tsx#L197

panaC avatar May 07 '24 14:05 panaC

As far I know, I'm stuck on this issue

panaC avatar May 14 '24 14:05 panaC

I need help @danielweck to solve this issue

panaC avatar May 17 '24 17:05 panaC

https://github.com/radix-ui/primitives/issues/966

panaC avatar May 27 '24 08:05 panaC

Will it be possible for Thorium to ultimately rely on a single technology solution like Adobe Spectrum / React ARIA Components (which under the hood uses React Stately and React ARIA Hooks), and avoid mixing other keyboard/focus-handling components from Radix? My understanding is that RACs are systematically and methodically tested with screen readers, with a great level of attention to detail. I am not sure that Radix focusses as hard on solving the finer issues. Maybe I am wrong though, not speaking from experience, just from listening / reading other developers' feedback.

danielweck avatar May 27 '24 09:05 danielweck

Duplicate: https://github.com/edrlab/thorium-reader/issues/2147

danielweck avatar May 27 '24 13:05 danielweck