edrlab
[WIP] Reader Themes
I merge develop then npm run start:dev
I open a book : the webview is night but the library theme is neutral (light)
Weird, is it a theme migration issue on my machine ?
npm install to ensure package navigator is up to date?
Same I will check why
fixed with 41252a395e8470b7f02708d8cab8da279a33934d
Hello, how hard would it be to introduce one additional theme, this one would be special because it would allow users to choose background and foreground colours using a picker? (let's ignore hyperlinks colour for now)
https://react-spectrum.adobe.com/releases/2024-05-01.html
In addition, we have added a suite of new color components including ColorPicker, ColorArea, ColorField, ColorSlider, ColorSwatch, ColorSwatchPicker, ColorWheel, currently in beta. These enable you to build fully customizable color pickers, including accessible color descriptions for screen reader support.
PS: note the colour swatch picker, it is a radio too :) (keyboard tab + arrows)
https://react-spectrum.adobe.com/react-aria/ColorSwatchPicker.html
I feel that this PR is a very good start, even if the choice of annotation colours is suboptimal (see the issue I logged about contrast and differentiation). We can iterate later about the user-picked custom colours functionality, this is a good stretch goals but not critically blocking for the release. I am particularly interested in getting this PR merged because the "DB" (state) changes impact our testing workflow, for example when switching from this PR branch back to another (like develop) after having changed the app theme. So @arthur-lemeur do you have any pending code in the PR branch? What do you think about merging now so that the PR doesn't lag behind much longer?