[Linux package] Icon's path is "0x0" (electron-builder issue?)

[ghost]

SUMMARY

In the prebuilt Linux .deb package by EDRLab, the icon's path is "0x0": /usr/share/icons/hicolor/0x0/apps/thorium.png

The path is probably invalid as KDE's application launcher won't show the icon. The path should have been "1024x1024".

From this electron-builder document:

Linux icon set will be generated automatically based on the macOS icns file or common icon.png. Or you can put them into the build/icons directory if you want to specify them yourself. The filename must contain the size (e.g. 256x256.png) of the icon. Recommended sizes: 16, 32, 48, 64, 128, 256 (or just 512).

[ghost]

This bug is still present in v1.7.0.

---

EDIT:

The icon may be too big. From this comment:

The biggest icon size supported by the hicolor theme definition is 512x512. Putting larger icons there is not going to make desktops pick them up, if they follow the icon theme spec.

Copying the icon to /usr/share/pixmaps instead can workaround this problem.

[danielweck]

Code link (missing icon property): https://github.com/edrlab/thorium-reader/blob/2ad37fa8d4753c308b6d39b3f7c9439e09d93447/package.json#L217-L227

Electron Builder doc: https://www.electron.build/configuration/linux

[danielweck]

Merged issue: https://github.com/edrlab/thorium-reader/issues/1721

App icon is missing when Thorium is in the Ubuntu dock. But the app icon appears correctly when Thorium is running.

[panaC]

I seems this PR fixed the issue. Can you confirm for me on your side ?

[elcste]

The icon appears properly now in Ubuntu 22.04 with the latest dev version deb package.

[panaC]

many thanks @elcste

[danielweck]

Thank you for confirming so quickly, @elcste :)