thorium-reader icon indicating copy to clipboard operation
thorium-reader copied to clipboard

[PARKED] (DO NOT MERGE) support for MAS Mac App Store

Open danielweck opened this issue 5 years ago • 2 comments

Currently fails. See: https://github.com/readium/readium-desktop/issues/97#issuecomment-618898849

danielweck avatar Apr 25 '20 09:04 danielweck

Daniel - I have recent experience of jumping through the latest Catalina notarisation hoops for Apple. If you need help let me know!

CircularKen avatar Apr 25 '20 09:04 CircularKen

Thanks Ken. The problems we are experiencing are specific to Electron, but generally-speaking the MAS process can fail at various points in the build chain, and the error feedback from Apple's tooling / server is pretty sparse (dare I say, "useless" at times). Oh, and setting up the correct entitlements + provisioning profiles depending on the build type is pretty cumbersome :)

MAS is not a super high priority for Thorium right now, but we would like figure-out what the blockers are (if any). Thorium ships a couple of native NodeJS libraries which can be problematic, if improperly signed or handled in the sandbox context of a MAS app. There are also Electron APIs that simply do not pass the MAS compliance filter ("single instance lock", for example). Plus, the readium-desktop SDK launches its own HTTP(S) server on a localhost port, so there's that as well.

Fun stuff ;)

danielweck avatar Apr 27 '20 16:04 danielweck