Edoardo Putti

Results 34 comments of Edoardo Putti

> Which parts? > > For luacheck: `luacheck -q {reader,setupkoenv,datastorage}.lua frontend plugins spec` (Cf. https://github.com/koreader/koreader/blob/master/.ci/check.sh#L42) Thanks. I think this will be enough. Most of the CI builds are because I...

> For what's it's worth, I have used xpcall in frontend/ui/trapper.lua and plugins/httpinspector.koplugin/main.lua. Also see how much performance loss there could be with xpcall vs. pcall, plugins may get lots...

I am done and happy with the result. I will submit a second PR for errors when loading plugins.

@NiLuJe any comment on the plugin handlers sandbox that I can address?