Remove `isShallow` check on root source

Open MattSturgeon opened this issue 6 months ago • 2 comments

This seems to fix #74, by still using fetchGit even when the git repo is shallow.

I suspect this means issues similar to #74 can still occur when the flake is not a git repo, perhaps due to an underlying issue with "${src}" not correctly copying to store in some scenarios when nix-instantiate --eval is used?

Jul 12 '25 13:07 MattSturgeon

Bumping for feedback 🙃

Nov 07 '25 03:11 MattSturgeon

Another friendly bump

Dec 08 '25 09:12 MattSturgeon

CC @roberth for review.

Dec 25 '25 11:12 Eveeifyeve

Seems reasonable, and I like that this is a simplification.

isShallow and its usage were introduced in https://github.com/NixOS/flake-compat/commit/2c2a50af4dd77d8457284301b521448289b5a3ed without explanation why isShallow would have been a prerequisite for validity. Shallow repos should work just fine.

Dec 25 '25 11:12 roberth