Eelco Dolstra

Results 299 comments of Eelco Dolstra

Since this is a new feature and not a bug fix (AFAIK) we shouldn't backport it to 2.4.

This changes evaluation results, which is potentially a big problem...

I don't think this is a good approach. Being forced to move almost the entire source tree into a subdirectory just to work around a Nix issue is *not* best...

What's the use case for this? Why does it need a separate option rather than a `debug(...)` message?

> This means the locks are held until the process terminates. I don't think this is the case in general. `outputLocks` will be released via RAII from the goal's destructor....

For the new UI, we have to careful about adding features that are not discoverable or have a steep learning curve. For instance, in the example ``` nix shell --expr...

> Wasn't this already replaced with nix run? No, `nix run` doesn't start a shell, it directly runs the specified app or the default program from a package. > nix...

I'm not really fond of abusing comments for documentation. That's what you do when you don't control the language and don't have a way to add documentation in a more...

Shoving documentation into comments and then trying to correlate the comment with some nearby identifier is the sort of hack you do when you can't add documentation as first-class syntax...