Eelco Dolstra
Eelco Dolstra
> Do we need isStorePath? I don't think so We do need that to ensure it's only used for store paths where we know their ingestion method. As mentioned above,...
Can you add a release note for this?
Yeah, it should be generalized, e.g. `warnings = url-literals ...`. And then there could be an flag like gcc's `-Werror` to convert warnings into errors.
I'm not sure that `builtins.readFile` *should* support special files. Our notion of FSOs doesn't include them after all, and they're not very pure/reproducible. What's the use case for this? If...
> but we used to support them (and we still do on macOS), so we shouldn't break that I don't know if we *have* to guarantee perpetual bug-compatibility. FWIW, reading...
I'm pretty wary about adding a lot of complexity to support Windows, if we haven't even decided whether we want that, what that would look like, and whether there is...
It's failing on macOS: ``` error: output '/nix/store/nlr5js861c7rwa7mhxak18ai1s7hi2ia-nix-2.20.0pre20240112_e60cba3' is not allowed to refer to the following paths: /nix/store/wvc9zbsgipk9sps4y4ys3yrrnxzf8abg-boost-1.79.0 ```
Is this still needed? The build issue seems to have gone away.
@Ericson2314 Is this still an issue now that #6134 is merged?
@yorickvP Can you reformat the C/C++ code to follow the Nix coding style? See https://github.com/NixOS/nix/blob/29d6097b906ce36581549d8d7f001c54a56a9a0a/.clang-format. The same applies to file names, e.g. `nix_api_expr.cc` should be `nix-api-expr.cc`.