cariddi icon indicating copy to clipboard operation
cariddi copied to clipboard

Feat/save responses to output directory provided in new -srd flag and also print if in json if -json flag enabled fixes #128, #129, #130

Open kartikeysemwal opened this issue 1 year ago • 10 comments

Fixes #129 The code changes include new -srd flag. The directory will be used to save all the output files, such textOutput, htmlOutput, indexResponses and raw response. Earlier all these file used to be saved in the "output-cariddi" in the same directory.

Fixes #130 The output path of the stored response will also be printed in the json output if -json flag is enabled

kartikeysemwal avatar Aug 17 '24 11:08 kartikeysemwal

Hi @kartikeysemwal ! Thanks for your work and contribution. Really appreciated.

Two actions are failing (go build and linter). Please fix them before I start a review : )

If you need any help/assistance I'm here !

edoardottt avatar Aug 27 '24 13:08 edoardottt

@edoardottt updated according to the workflow errors, could you please rerun and check

kartikeysemwal avatar Aug 27 '24 14:08 kartikeysemwal

any update on this review?

edoardottt avatar Sep 06 '24 06:09 edoardottt

Hi @edoardottt, yes I will update the PR by weekend. But do we agree on StoreResp part in the first review comment.

kartikeysemwal avatar Sep 06 '24 12:09 kartikeysemwal

Hi @edoardottt, yes I will update the PR by weekend. But do we agree on StoreResp part in the first review comment.

yes, we do :)

edoardottt avatar Sep 06 '24 12:09 edoardottt

@edoardottt , PR is updated, incase you missed

kartikeysemwal avatar Sep 10 '24 17:09 kartikeysemwal

yes I agree with you. Let me add some layer of validation and test cases accordingly.

kartikeysemwal avatar Sep 18 '24 15:09 kartikeysemwal

@edoardottt , update the PR based on review

kartikeysemwal avatar Sep 18 '24 16:09 kartikeysemwal

Hi @kartikeysemwal , both Go / build and golangci-lint / lint actions are failing

edoardottt avatar Sep 20 '24 09:09 edoardottt

@edoardottt, I have updated the PR. Apologies for the inconvenience. The build failures were specific to the Linux system, and I initially created the PR on a Windows machine. Unfortunately, my WSL is currently broken, so I wasn't able to verify the new commit locally.

kartikeysemwal avatar Sep 20 '24 15:09 kartikeysemwal