Ed Morley

Results 642 comments of Ed Morley

To add yet more things to think about - Poetry has just merged support for [PEP-621](https://peps.python.org/pep-0621/) and the `[project]` section of `pyproject.toml`, in: https://github.com/python-poetry/poetry/pull/9135 This means Poetry 2.0 (expected later...

Given all of the above, I'm wontfixing this for now in favour of having a single way to specify the Python version - using a `.python-version` file.

> that buildpacks aren't normally on Docker Hub? The upstream CNB project has a buildpack registry, that acts as an index/mapping of buildpack ID and version to remote image URIs...

Hi In facebook/create-react-app#5140 the package in question mistakenly set `"sideEffects": false` even though it includes CSS, which caused the CSS to be dropped when `mode` was `'production'`. This lead to...

Searching GitHub issues for "webpack css sideEffects" shows there appears to be pretty widespread confusion regarding `"sideEffects"` and CSS with the current API design/docs/lack of warning. For example in addition...

@atalman Thank you for the initial review. I've made the suggested changes and rebased on latest `main` :-)

@atalman Hi! I don't suppose you have time for a re-review? :-)

@atalman Hi! Your review comments have been addressed (back in Feb), and I've just rebased again on `main`. I don't suppose you could re-review and merge? Thanks :-)

As of #1439 and #1446 the Ruby install parts of the classic Ruby buildpack supports ARM64 on Heroku-24. However, when I attempt the build of the getting started Rails app,...

Fixed by #1493 / #1499 (not yet released, but available via the GitHub buildpack URL in the meantime).