Ed Morley

Results 459 comments of Ed Morley

As an added bonus, if we were to add a `cargo libcnb run` command, we could then perhaps make `cargo libcnb package` default to `--release` (given the primary use-case of...

The problem with a default of `ExistingLayerStrategy::Keep` is that the default implementation won't be able to log a "Keeping X because Y" (or even just "Reusing cached layer"), since we...

> the "why is my thing not changing when I've changed my code" is probably less confusing since it would only occur when you explicitly write `cache: true` in your...

Yeah I realise it mirrors `cargo build`. I think there is more potential for gotchas in our case though, since: - there's a chance people using libcnb.rs are slightly less...

In parallel with the options listed in the OP, we should at the least also document `--release` in the `libcnb-cargo` README, and maybe also mention "packaging for production" in the...

Since this issue was opened: - `LayerResultBuilder` / `LayerResult` were introduced (in #144) - `DetectResultBuilder` and `BuildResultBuilder` were changed to match `LayerResultBuilder`'s wrapping in a `Result` (in #209) - The...

@AidanDelaney This one also isn't fixed and needs reopening: https://buildpacks.io/docs/reference/config/project-descriptor/

@AidanDelaney Please can you reopen this? It's not fixed: https://buildpacks.io/docs/reference/config/project-descriptor/

@AidanDelaney I believe this is still needed, and should be reopened?

cc @jromero - I think you might be the best person to review given recent the git log (I'm not able to select you as a reviewer via the GitHub...