Ed Morley
Ed Morley
@iloverink Hi! What version of Pack CLI is that using?
The comments in this issue so far have actually been about three separate things: 1. That `cargo libcnb package` gives a confusing `No buildpacks found!` error message if `buildpack.toml` parsing...
Thank you for the PR. Just to set expectations timing wise - I won't have a chance to look at this PR until next week, since there are several things...
@joshwlewis The tests are failing with: ``` ---- tracing::tests::test_tracing stdout ---- tracing_contents: {"resourceSpans":[{"resource":{"attributes":[{"key":"service.version","value":{"stringValue":"0.0.99"}},{"key":"service.name","value":{"stringValue":"company.com/foo"}}]},"scopeSpans":[{"scope":{"name":"libcnb","version":"0.19.0"},"spans":[{"traceId":"7deae25accd2519109a45a7d05bb5cb2","spanId":"f599048ca08001f7","parentSpanId":"0000000000000000","name":"company_com_foo-bar","kind":1,"startTimeUnixNano":1709116666323150356,"startTime":"2024-02-28 10:37:46.323","endTimeUnixNano":1709116666323166256,"endTime":"2024-02-28 10:37:46.323","attributes":[{"key":"buildpack_id","value":{"stringValue":"company.com/foo"}},{"key":"buildpack_name","value":{"stringValue":"Foo buildpack for company.com"}},{"key":"buildpack_version","value":{"stringValue":"0.0.99"}},{"key":"buildpack_homepage","value":{"stringValue":""}}],"droppedAttributesCount":0,"events":[{"name":"baz-event","attributes":[],"droppedAttributesCount":0,"timeUnixNano":1709116666323158401,"time":"2024-02-28 10:37:46.323"},{"name":"exception","attributes":[{"key":"exception.message","value":{"stringValue":"it's broken"}}],"droppedAttributesCount":0,"timeUnixNano":1709116666323165324,"time":"2024-02-28 10:37:46.323"}],"droppedEventsCount":0,"flags":1,"droppedLinksCount":0,"status":{"message":"Custom { kind: Other, error: \"it's broken\" }","code":2}}]}]}]} thread 'tracing::tests::test_tracing'...
I've also removed the "skip changelog" label to remind us to confirm whether this is a breaking change or not for consumers of the `/tmp/libcnb-telemetry` file or not. ie: Will...
I think we should maybe focus on fixing the default behaviour upstream instead of this - see: https://github.com/buildpacks/spec/issues/285
This is something that should be fixed/improved (either here or upstream), but as a workaround in the meantime, update to latest pack CLI, since it trusts the `heroku/builder:22` image by...
Note: The `log` module will be removed in the future, since it's been superseded by the `build_output` module, which handles the case in the OP correctly.
Shipping the buildpack's `LICENSE` file in the packaged `.cnb` and OCI image seem like the best approach to me. The assembling of libcnb.rs powered component buildpacks occurs here: https://github.com/heroku/libcnb.rs/blob/a9759eef8e356f6396f1df8b16afe591645251d5/libcnb-package/src/lib.rs#L48 For...