rdf-toolkit icon indicating copy to clipboard operation
rdf-toolkit copied to clipboard

Invalid tests org.edmcouncil.rdf_toolkit.writer.SortedRdfXmlWriterTest

Open przemekgradzki opened this issue 1 year ago • 1 comments

The error described in #67 was not detected in the tests because the algorithm used in them is incorrect.


How to reproduce the error:

  1. Clone the rdf-toolkit repository in the version containing issue #67 and build project without tests:
    git clone https://github.com/edmcouncil/rdf-toolkit
    cd rdf-toolkit
    git reset --hard 2603921
    mvn -Dmaven.test.skip=true clean package
    
  2. Perform tests with different ordering of files in the src/test/resources/ontologies/literal directory (executed on Oracle Linux Server release 8.9 with XFS filesystem):
    1. test1.jsonld test1.rdf test1.ttl - will end with [ERROR] Tests run: 85, Failures: 4, Errors: 0, Skipped: 2, i.e. identifying issue #67:
      mv src/test/resources/ontologies/literal/* /tmp/
      mv /tmp/test1.{jsonld,rdf,ttl} src/test/resources/ontologies/literal/
      
      # check the order of files - the following command:
      ls -f src/test/resources/ontologies/literal/
      # should return:
      #    .  ..  test1.jsonld  test1.rdf  test1.ttl
      
      mvn test
      
    2. test1.rdf test1.ttl test1.jsonld - will end with a BUILD SUCCESS message, which is an incorrect result because #68 is not applied to the code yet:
      mv src/test/resources/ontologies/literal/* /tmp/
      mv /tmp/test1.{rdf,ttl,jsonld} src/test/resources/ontologies/literal/
      
      # check the order of files - the following command:
      ls -f src/test/resources/ontologies/literal/
      # should return:
      #    .  ..  test1.rdf  test1.ttl  test1.jsonld
      
      mvn test
      

przemekgradzki avatar Mar 14 '24 18:03 przemekgradzki

What are the standard versions( java, maven, etc) and commands (e.g. mvn clean package) for building the develop branch? I'm getting a bunch of errors and no build at the moment

pwin avatar Jun 06 '25 14:06 pwin