Edward Kimmel comments

Results 15 comments of


                                            Edward Kimmel

React 18 concurrent render functions / removal of findDOMNode / test updates

> Does this mean we can use strict mode now? IIRC, that was one of the existing issues last time we looked into it. Removing `findDOMNode` is a step towards...

React 18 concurrent render functions / removal of findDOMNode / test updates

@necolas I pushed a small change + test to return an object containing an unmount method from runApplication. It hides whether we used react 17 or 18 render/hydrate methods and...

React 18 concurrent render functions / removal of findDOMNode / test updates

@necolas Should I close this PR? I just saw the commit on 0.19-dev referencing this PR.

React 18 concurrent render functions / removal of findDOMNode / test updates

> Do you know on which update this will be fixed ? Thank you ! @JinbeiStudio This is part of 0.19 https://github.com/necolas/react-native-web/pull/2377 I don't know when that release is expected...

The client.isOpen is true even when the connection has failed during client.connect(), if redis server is not online.

@leibale I have seen a similar problem here. It's my understanding that isOpen=true, isReady=false should indicate that node-redis is actively trying to connect / reconnect, but I have had some...