Introduced the project_icon key
Here is the draft of the project_icon pair. The key/value description is open to discussion.
CC: @xuhdev @florianb @cxw42
π Documentation preview π: https://editorconfig-specification--89.org.readthedocs.build/
+ Konstantin from JetBrains @kaleev
Hey Konstantin!
The issue is mostly inspired by Jet Brains's IDEs and their project icons support. To clarify the intention - we want to introduce the key/value pair, that outlines the icon to be used for the project in various themes.
So, as far as I know, Jet Brains IDEs are not limited to Light and Dark themes, there are more of them, plus possible community themes as well.
So, how does Intelj, for instance, resolves the icon for the current theme? For instance, the icon.svg best to my knowledge is used for the light theme, icon_dark.svg for the dark theme, but what if the user selects other theme, or a community theme? How Intelij resolves the icon in this case? What is the general algorithm here?
Apart from that, it would be great if you'll be able to take a look at specification of the project_icon key/value pair.
Just make sure you are aware, this must be sent to editorconfig/vote first before merging.
@xuhdev I have a couple of questions in regard to voting:
- Do I just create an issue in the
editorconfig/voterepository? - What are the options for voting should be? I can see just binary - introduce/not introduce
@xuhdev I have a couple of questions in regard to voting:
1. Do I just create an issue in the `editorconfig/vote` repository?
Yes, there's a issue template.
2. What are the options for voting should be? I can see just binary - introduce/not introduce
Yes, usually we have discussion done somewhere and then vote on a binary decision. That repo isn't for discussion.
Also this feature runs afoul of the first paragraph of the spec:
EditorConfig helps maintain consistent coding styles for multiple developers working on the same project across various editors and IDEs.
It should be probably discussed first, as this introduces extra maintenance burdens, and we already lack manpower.
Hi, sorry for the delay. Each theme in IntelliJ IDEA has a boolean dark attribute that determines whether itβs based on the Light or Darcula theme family. When resolving the icon, IntelliJ IDEA uses this dark flag to select the appropriate icon variant. This approach works across all JetBrains IDEs.