editorconfig-vim icon indicating copy to clipboard operation
editorconfig-vim copied to clipboard

Stop setting 'softtabstop'

Open chreekat opened this issue 4 years ago • 3 comments

  1. Vim already supports having 'softtabstop' equal to 'shiftwidth'.
  2. I think 'softtabstop' is really a UI tweak, not a filetype setting.

This bit me when I finally decided I didn't like softtabstop, and started setting it to 0 in ~/.vimrc. ;)

chreekat avatar Feb 25 '20 10:02 chreekat

@chreekat Thanks for this PR! What conditions have you tested? I know this works for your use case. However, before changing core plugin behaviour, we need to know that it works for everyone else's use cases (as much as possible).

Also, what caused you to make this change? Does it fix an actual problem you encountered?

cxw42 avatar Feb 25 '20 12:02 cxw42

@cxw42 , thank you for your questions!

I have not tested any conditions. Are there automated tests? Should there be more? I could write one. But I suppose there are many users who are used to the existing settings. This could be optional?

Also, what caused you to make this change? Does it fix an actual problem you encountered?

Yes. Setting 'softtabstop' changes the behavior of the backspace key in Insert mode. I had tried it out for a while and found I didn't like it, so I turned it off. This plugin turned it back on.

chreekat avatar Feb 25 '20 16:02 chreekat

@chreekat Thanks! I will try out the non-sts backspace. Let's leave this open for a few days and see if any other users weigh in with their experiences.

cxw42 avatar Feb 26 '20 03:02 cxw42

@chreekat Sorry for the long delay! Would you please join the discussion at #198?

cxw42 avatar Oct 30 '22 20:10 cxw42

Thanks! Closing in favor of #198 .

(Unfortunately I don't use EditorConfig anyway.)

chreekat avatar Oct 31 '22 07:10 chreekat