editorconfig-core-js icon indicating copy to clipboard operation
editorconfig-core-js copied to clipboard

Add file information

Open hildjj opened this issue 3 years ago • 3 comments

Fixes #79.

There are other APIs that would work, I'm sure, but this one:

  • Does not change the way the function is called
  • Does not change the displayed output from the CLI
  • Should not impact any existing users that do not want the information

hildjj avatar Oct 10 '22 21:10 hildjj

Pull Request Test Coverage Report for Build 3222395575

  • 0 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.8%) to 100.0%

Totals Coverage Status
Change from base Build 3222275643: 0.8%
Covered Lines: 386
Relevant Lines: 386

💛 - Coveralls

coveralls avatar Oct 10 '22 21:10 coveralls

Pull Request Test Coverage Report for Build 3222395575

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 37 of 37 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 98.502%

Totals Coverage Status
Change from base Build 3222275643: -0.7%
Covered Lines: 386
Relevant Lines: 386

💛 - Coveralls

coveralls avatar Oct 10 '22 21:10 coveralls

Changed the API. The Symbol thing was a little too cumbersome, and as I started to play with caching, I decided I wanted the files API to have a similar shape to what I'm planning there. This is a hair less convenient to call, with the upside being it will definitely not break any existing code.

hildjj avatar Oct 13 '22 07:10 hildjj