editor-js
Bump package.json version from 2.4.1 to 2.4.2
- Updated package.json version from 2.4.1 to 2.4.2.
- Added maxRows and maxCols features to limit the number of rows and columns.
- Updated README.md to reflect the new features .
Why have you merged #165 without 2 approvals? And also, please do not resolve other people's comments. Ask them to review instead. Only author of a comment should resolve it after checking that he has no questions.
What does it mean "5 by params"? By default there should not be any rows and cols limitations
What does it mean "5 by params"? By default there should not be any rows and cols limitations
Since I've added maxRows: 5 and maxCols: 5 to both config and index.html, the table now displays only 5 rows and 5 columns when these parameters are passed as an example ,.
Should I remove or modify them?
What does it mean "5 by params"? By default there should not be any rows and cols limitations
Since I've added maxRows: 5 and maxCols: 5 to both config and index.html, the table now displays only 5 rows and 5 columns when these parameters are passed as an example ,.
Should I remove or modify them?
I still did't get what does it mean "by params" in README. Which params? You need to update the Readme making it more clear for developers. Mention that they are optional params.
Another think is code duplication. You have many similar fragments like these:
Instead of adding it in many places, create a method updateAddColumnButtonState() and simply call it where needed
Another think is code duplication. You have many similar fragments like these:
Instead of adding it in many places, create a method
updateAddColumnButtonState()and simply call it where needed
created updateAddButtonstate , handles repeated logic
What does it mean "5 by params"? By default there should not be any rows and cols limitations
Since I've added maxRows: 5 and maxCols: 5 to both config and index.html, the table now displays only 5 rows and 5 columns when these parameters are passed as an example ,. Should I remove or modify them?
I still did't get what does it mean "by params" in README. Which params? You need to update the Readme making it more clear for developers. Mention that they are optional params.
updated readme.md , removed params , made it more clear