image icon indicating copy to clipboard operation
image copied to clipboard

make some methods public

Open lukaszb opened this issue 1 year ago • 2 comments

This allow users to override i.e. tuneToggled and access data. Without it actions config is very limited and it's hard to extend plugin.

lukaszb avatar Oct 22 '24 11:10 lukaszb

Please, describe your case with more details.

neSpecc avatar Oct 22 '24 13:10 neSpecc

@neSpecc hey, for example I wanted to allow user to resize image to 25%, 50% and full width. I also wanted selected size to be highlighted. I've added actions to config but also needed to override tuneToggled and use setTune - mainly to recognize if another size has been previously selected and if so - deselect it.

lukaszb avatar Oct 22 '24 15:10 lukaszb

@neSpecc hey, for example I wanted to allow user to resize image to 25%, 50% and full width. I also wanted selected size to be highlighted. I've added actions to config but also needed to override tuneToggled and use setTune - mainly to recognize if another size has been previously selected and if so - deselect it.

It should be designed first. Create an issue with short but detailed explanation what you want to achieve and why current config does not allow that.

We can't just expose some private methods.

neSpecc avatar Oct 28 '24 13:10 neSpecc