edison comments

Results 401 comments of


                                            edison

fix(runtime-core): comments before single root element breaking Transition

/ecosystem-ci run

fix(hmr):using customElements after hmr will trigger an error

I think this is outside the scope of vue. the developers should ensure that custom elements are not registered many times. [Playground](https://play.vuejs.org/#eNp9UstOwzAQ/BXjSxIppIL2VIVKUPUAB0DA0Zco2bQufkR+lKIq/87a6UuocNvdmV3NjL2j911XbDzQKS1tbXjniAXnuxlTXHbaOLIjBtq8gZYrmHvrtFwIkKBcvupJa7QkCe4nTDFVa2UdmWvZkTtyYSPdMUWIqiRMGQ00RvMwMaAaMGkW4dA6bxRZpYw2fIMc5YXIb24n4ywQeqZ6LHibXtXn122xBJcm8vu6xtNJlpFf8KDoxMiDBLxUjgbn6BkbB7ITlQPsCCn33Fk5OlRhHHaOPJpTZ9F6y5fF2mqFUUYjjAY+F2BeOscxGkanZG+R0UoI/fUUZ854iDnEnRXUnxfma7sNM0ZfDVgwG9hnFzBXGbQ+wIv3Z9hifQSlbrxA9j/gG1gtfNA40B68alD2GS+qfYwfgqvlh11sHSh7MBWExpeJfEbxP4Ro/7J+kjsuJocXpf0P8vHa8g==)

fix(runtime-dom): use offsetLeft and offsetTop instead of getBoundingClientRect to avoid transform scale affect animation

- [Playground](https://play.vuejs.org/#eNqlVMFu2zAM/RVCwFAHiJ102S5eUmAbeugO27DtMkw7uA6dqLUlQZLdFIH/fZSUOGkXBAV6I/neox4p2Vv2Ueusa5HlbG5LI7QDi67VV1yKRivjYAsGK+ihMqqBC6JecMllqaR1cNs6RwEsPCf5wyXA5RjejmHG5d8Rl9TqRjo0XVEnyQgWV7D1nGMxaXddMmK1mNm1qFxCYngG6Nauk1gitKdDptMpRfNJNE6WKXHY6LpwSBnAfCk6sO6xxgVnzhTSVso0OdiyqDHJ3o84CzxiBlQ4oWS6MqrVIIvGq6pa6IFFvJ3rLqVOBO9SIfdmOYP8Hh8H6EgLsN3up+77oeMklvZGJs+dxEkmNEqMXuT0NT7/d/nE40mHVDwsntKwdAp3jcK1H2Q5FHUNMwtYWPzgsQexdOscLqfTN5TTsVxmfqC0xqLD1KmjFvEOQ+gP/J2kXjZ6qkP/7tLwaM8oTwjjgUXpRIdRqtXg+taqunXeMino4YUp2Zg5S2+6EqvszipJ31LQcVaqRosazTft9bTzPHb0GG1APXwJNWdaHO/r5RrL+xP1O7vxNc6+G7T0SSFnA+YKs0IX4eufX3FD8QA2atnWxD4D/sAwF3mMtE+tXJLtI15wexP+CEKuftnrjUO6zN1Q3qhn9oHPGf0lPp8Z/WB3lr0LOton6/8Bs/mJNQ==) - [Playground with this PR](https://deploy-preview-6108--vue-sfc-playground.netlify.app/#eNqlVMFu2zAM/RVCwFAHiJ102S5eUmAbeugO27DtMkw7uA6dqLUlQZLdFIH/fZSUOGkXBAV6I/neox4p2Vv2Ueusa5HlbG5LI7QDi67VV1yKRivjYAsGK+ihMqqBC6JecMllqaR1cNs6RwEsPCf5wyXA5RjejmHG5d8Rl9TqRjo0XVEnyQgWV7D1nGMxaXddMmK1mNm1qFxCYngG6Nauk1gitKdDptMpRfNJNE6WKXHY6LpwSBnAfCk6sO6xxgVnzhTSVso0OdiyqDHJ3o84CzxiBlQ4oWS6MqrVIIvGq6pa6IFFvJ3rLqVOBO9SIfdmOYP8Hh8H6EgLsN3up+77oeMklvZGJs+dxEkmNEqMXuT0NT7/d/nE40mHVDwsntKwdAp3jcK1H2Q5FHUNMwtYWPzgsQexdOscLqfTN5TTsVxmfqC0xqLD1KmjFvEOQ+gP/J2kXjZ6qkP/7tLwaM8oTwjjgUXpRIdRqtXg+taqunXeMino4YUp2Zg5S2+6EqvszipJ31LQcVaqRosazTft9bTzPHb0GG1APXwJNWdaHO/r5RrL+xP1O7vxNc6+G7T0SSFnA+YKs0IX4eufX3FD8QA2atnWxD4D/sAwF3mMtE+tXJLtI15wexP+CEKuftnrjUO6zN1Q3qhn9oHPGf0lPp8Z/WB3lr0LOton6/8Bs/mJNQ==) To be sure, the problem was fixed. re-use test case from #9733

fix(runtime-dom): use offsetLeft and offsetTop instead of getBoundingClientRect to avoid transform scale affect animation

/ecosystem-ci run

feat(compiler-core): allow directive modifiers to be dynamic (fix #8281)

> I developed on top of the main branch but the guidelines say to submit against minor. Now I have this extra commits in my history. Not sure how to...

feat(compiler-core): allow directive modifiers to be dynamic (fix #8281)

Thank you very much for your contribution. This PR is really great. I did a quick test and found the following issues. - ### v-model dynamic modifiers on component the...

feat(compiler-core): allow directive modifiers to be dynamic (fix #8281)

> I have a bit of duplicated code now. Let me know if I should refactor that and if so, where I put helper functions for such things We can...

feat(compiler-core): allow directive modifiers to be dynamic (fix #8281)

/ecosystem-ci run

feat(compiler-core): allow directive modifiers to be dynamic (fix #8281)

Thanks @Fuzzyma Nick work and LGTM~

feat(compiler-core): allow directive modifiers to be dynamic (fix #8281)

@Fuzzyma > can i somehow checkout this PR ins vue-sfc to test it easily? We can use the following version to install the [PR preview package](https://github.com/vuejs/core/pull/12913#issuecomment-2670531941) ```bash npm i https://pkg.pr.new/vue@12913...