edison comments

Results 401 comments of


                                            edison

fix(keep-alive): only prune cache if include/exclude not null

> @edison1105 Like that? Yes

types(reactivity): optimize the display type of ref

@yangliguo7 Could you please add a test case for this?

types(reactivity): optimize the display type of ref

/ecosystem-ci run

fix(reactivity): avoid error during nested watch stop

> @edison1105 Because of [this](https://developer.mozilla.org/zh-CN/docs/Web/JavaScript/Reference/Global_Objects/Array/forEach#%E5%A6%82%E6%9E%9C%E6%95%B0%E7%BB%84%E5%9C%A8%E8%BF%AD%E4%BB%A3%E6%97%B6%E8%A2%AB%E4%BF%AE%E6%94%B9%E4%BA%86%EF%BC%8C%E5%88%99%E5%85%B6%E4%BB%96%E5%85%83%E7%B4%A0%E4%BC%9A%E8%A2%AB%E8%B7%B3%E8%BF%87%E3%80%82), I feel this can use: > > ```js > while (this.effects.length) { > this.effects[0].stop() > } > ``` but, Not every `effect.stop()` will change the...

fix(reactivity): avoid error during nested watch stop

@skirtles-code Thank you so much.

fix(runtime-core): merge return value when there is undefined value in `withDefaults`

Could you please resolve the conflicts?

fix: ensure tracking is paused when emit() calls handler so it can safely be called in effects (fix #6669)

I feel this PR is necessary though ##6669 is closed.

fix(runtime-core): named ref, Non-ref data should not be contaminated

This usage does not work in the production build, and there is a warning if you use a non-ref value hold element(via https://github.com/vuejs/core/pull/12051). So, maybe this PR is no longer...

fix(compiler-core): prevent root comments from blocking static node hoisting

/ecosystem-ci run

fix(compiler-core): prevent root comments from blocking static node hoisting

@skirtles-code > I think this would benefit from some extra tests in stringifyStatic.spec.ts too. For example, testing a case like this: Added via https://github.com/vuejs/core/pull/13345/commits/fdbb6249aabc4110ed146c36228fcce6ef619189