ciftify icon indicating copy to clipboard operation
ciftify copied to clipboard

make ciftify_meants work with wb_command versions ? 1.3.

Open edickie opened this issue 3 years ago • 1 comments

The problem Currently: https://github.com/edickie/ciftify/blob/master/ciftify/bin/ciftify_meants.py [line 100]

ciftify.utils.run(['wb_command', '-cifti-parcellate',
            settings.func.path, settings.seed.path,
            'COLUMN', tmp_parcelated, '-include-empty'])

BUT as of wb_command 1.4 (I believe) "'-include-empty' is deprecated but is now the default behaviour". However the deprecation warning kills the computation...

So ciftify needs to:

  1. detect the version of wb_command (actually I think we do this in ciftify.utils.wb_command_version()
  2. change behaviour of above section to remove '-include-empty'. if version is >=1.4
  3. test code with multiple versions of wb_command (note: I believe the CI is already set up for this?)

edickie avatar May 11 '21 19:05 edickie

What would be the recommended workbench version for ciftify?

marcelzwiers avatar Apr 26 '22 13:04 marcelzwiers