vscode-better-solarized icon indicating copy to clipboard operation
vscode-better-solarized copied to clipboard

Idea: use different colors for string delimiters and escape sequences

Open andronocean opened this issue 3 years ago • 1 comments

Hey — firstly, thank you for creating this theme. It's really well done! I've been happily using it for a couple weeks, and this is the first time I've found something that annoys me.

Right now, the color scheme used to highlight escape sequences is the same as what's used for highlighting quotation marks at the start and end of strings. So, if I'm escaping quote marks within a string, it looks like it's the end of the string at a glance, unless I look closely.

Here's a PHP example (though it's the same in JS):

better-solarized-escapes

By comparison, here's how another theme (Monokai Pro) handles the same escapes:

monokai-pro-escape-coloring

It's a little thing, but this would be a lovely detail to include.

andronocean avatar Mar 10 '21 22:03 andronocean

Let me see what I can do - I actually do use this theme as my daily driver.

I'm always open to PRs.

edheltzel avatar Mar 11 '21 22:03 edheltzel

@andronocean here is a preview of the update:

Better Selenized Dark: better-selenized-dark

Better Solarized Dark (italic is the same): better-solarized-dark

edheltzel avatar May 13 '24 18:05 edheltzel

Oh that's awesome! A belated thank you for this.

andronocean avatar Jun 17 '24 17:06 andronocean