web-monitoring-ui icon indicating copy to clipboard operation
web-monitoring-ui copied to clipboard

Be more graceful when Google sheets is not configured

Open Mr0grog opened this issue 6 years ago • 5 comments

Enough people have hit confusion around the Google sheets configuration that we really should clean this up. The current status is that it’s “optional” in the sense that certain routes are expected not to work and the app won’t crash if not configured. But we log config errors in that case and people get confused. So:

  • Methods that retrieve data from sheets should return early with nice errors if not configured (server/sheet-data.js)

  • The UI should not have an “assigned pages” view or support the assigned pages routes when sheets is not configured. This should probably be a config var named something like SHOW_ASSIGNED_PAGES for the front-end that is calculated based on the Google Sheets env vars. (server/configuration.js)

Mr0grog avatar Mar 12 '18 16:03 Mr0grog

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in seven days if no further activity occurs. If it should not be closed, please comment! Thank you for your contributions.

stale[bot] avatar Jan 10 '19 00:01 stale[bot]

This has been a barrier for some contributors, so I think it’s important to track and fix.

Mr0grog avatar Jan 10 '19 05:01 Mr0grog

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in seven days if no further activity occurs. If it should not be closed, please comment! Thank you for your contributions.

stale[bot] avatar Jul 09 '19 05:07 stale[bot]

Added never-stale label

lightandluck avatar Jul 09 '19 22:07 lightandluck

The sheets-related methods still need to return early if not configured, but we removed the assigned pages view and all the associated bits (the most painful part people were running into) in #395 and #398.

Mr0grog avatar Feb 03 '20 22:02 Mr0grog