edgedb-go icon indicating copy to clipboard operation
edgedb-go copied to clipboard

Add edgeql to go code generator

Open fmoor opened this issue 2 years ago • 6 comments

This change implements the default behavior outlined in https://github.com/edgedb/edgedb/discussions/4244. All arguments and options to the generator command are left for future work along with query hashing.

The documentation, help text, and cmd/edgeql-go/testdata directory may be areas of interest for reviewers.

This is related to https://github.com/edgedb/edgedb-go/issues/182

fmoor avatar Aug 05 '22 23:08 fmoor

Is edgeql-go an appropriate name for the go codegen binary?

cc @1st1 @colinhacks

fmoor avatar Aug 05 '22 23:08 fmoor

~This PR still needs tests added.~

fmoor avatar Aug 06 '22 00:08 fmoor

Ready for review

fmoor avatar Aug 16 '22 22:08 fmoor

@divan and anyone else that would like, we would love to have early feedback from the community on this feature if you are interested in trying it out.

fmoor avatar Aug 24 '22 21:08 fmoor

Currently all generated query functions are public. I think they should be private by default. Then if people ask for it we can provide a mechanism to tell the generator to make query functions public on a per query basis.

fmoor avatar Aug 27 '22 00:08 fmoor

~TODO: I need to look at linked property support~

fmoor avatar Oct 17 '22 17:10 fmoor