Error when linking a new instance and using `-I`

[aljazerzen]

• EdgeDB CLI Version: EdgeDB CLI 3.0.0-dev
• OS Version: Ubuntu 22.02

Steps to Reproduce:

1. edgedb instance link -I asxasxasx
2. Type anything when prompted for more info (I just pressed enter 3x)

edgedb error: ClientError: cannot read credentials file /home/aljaz/.config/edgedb/credentials/asxasxasx.json: No such file or directory (os error 2)

Full output:

➜  movies edgedb instance link -I asxasxasx
Specify the host of the server [default: localhost]:
> localhost
Specify the port of the server [default: 5656]:
> 5656
Specify the database user [default: edgedb]:
> edgedb
Specify the database name [default: edgedb]:
> edgedb
edgedb error: ClientError: cannot read credentials file /home/aljaz/.config/edgedb/credentials/asxasxasx.json: No such file or directory (os error 2)

[tailhook]

It looks like asxasxasx is a non existing instance, right? Logic of link command suggests that link -I is probably for copying credentials?

So I'd expect:

1. Not asking all those fields (we don't ask things defined on command-line)
2. Fail early (although, it's not invisible if no question asked)

In other words:

1. Check if source exists (probably validate that it's valid credentials file)
2. Ask name to copy to
3. Copy the file

Is this what you expect?

(also please add git hash when reporting version built from repository, it's git describe or git rev-parse --short HEAD).

[aljazerzen]

1. Check if source exists (probably validate that it's valid credentials file)
2. Ask name to copy to
3. Copy the file

Exactly.

(also please add git hash when reporting version built from repository, it's git describe or git rev-parse --short HEAD).

:+1: