edgedb-cli icon indicating copy to clipboard operation
edgedb-cli copied to clipboard

Published 20 hours ago • verified publisher icon edgedb

fish shell support for the installer

Open geohuz opened this issue 3 years ago • 4 comments

It seems that installer script doesn't support fish shell profile?

geohuz avatar Feb 15 '22 08:02 geohuz

Yes, we should add native support for fish profiles.

I use fish, but I don't set it as $SHELL and start it from .bashrc instead, so environment is picked up both by interactive fish and any bash scripts I run.

elprans avatar Feb 18 '22 22:02 elprans

Should we use fish_add_path https://github.com/rust-lang/rustup/issues/478#issuecomment-839537308, but only when running with $SHELL=fish. Or should we use drop a file into ~/.config/fish/conf.d/ (https://github.com/rust-lang/rustup/issues/478#issuecomment-284203225) ? So that even if someone uses multiple shells or will install fish later on, it still works?

tailhook avatar Feb 21 '22 11:02 tailhook

I think those aren't exclusive? fish_add_path is just a more canonical way of doing set -gx PATH.

elprans avatar Feb 21 '22 17:02 elprans

I think those aren't exclusive? fish_add_path is just a more canonical way of doing set -gx PATH.

fish_add_path is persistent as far as I understand. So it isn't very useful to do both.

tailhook avatar Feb 21 '22 18:02 tailhook