Edward Gao
Edward Gao
aren't trace messages more "this is why the sync failed"? I think there's cases where we catch an exception but don't fail and still want to log it (e.g. `LOGGER.warn("Caught...
This PR addresses both fatal and non-fatal exceptions, I'm just thinking through consequences for both cases. The fatal case is probably simple, since we can add a top-level try-catch to...
sounds good. The datetime problem seems to be happening on master as well, i.e. is unrelated to this PR - I think @Phlair is trying to solve it
@andriikorotkov fyi we have https://github.com/airbytehq/airbyte/issues/15172 to track the destination-postgres test failures. I didn't see an obvious root cause unfortunately. (cc @grishick )
thanks for the analysis! In that case, I think we should publish+merge this PR as-is.
/test connector=connectors/source-postgres > :clock2: connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2785534658 > :x: connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2785534658 > :bug: https://gradle.com/s/gfnawrvsw5ocq > ### Build Failed Test summary info: ``` Could not find result summary ``` > :clock2: connectors/source-postgres...
/publish connector=connectors/source-postgres > :clock2: Publishing the following connectors:connectors/source-postgreshttps://github.com/airbytehq/airbyte/actions/runs/2786007129 | Connector | Did it publish? | Were definitions generated? | | --- | --- | --- | | connectors/source-postgres | :x:...
/publish connector=connectors/source-postgres-strict-encrypt > :clock2: Publishing the following connectors:connectors/source-postgres-strict-encrypthttps://github.com/airbytehq/airbyte/actions/runs/2786007171 | Connector | Did it publish? | Were definitions generated? | | --- | --- | --- | | connectors/source-postgres-strict-encrypt | :x:...
can't publish until https://github.com/airbytehq/airbyte/pull/14801 is merged
@yurii-bidiuk I'll take over publishing here. Will merge https://github.com/airbytehq/airbyte/pull/15187/ into this one, get https://github.com/airbytehq/airbyte/pull/14801 merged to master, and update this PR's version numbers/changelog accordingly.