Crouton icon indicating copy to clipboard operation
Crouton copied to clipboard

BUGS in cloudmqtt-demo.py

Open manik23 opened this issue 3 years ago • 2 comments

There are several bugs in this demo python client.

  1. print() has missing brackets.
  2. Device setup JSON is not working properly.
  3. Port number should be integer

I would like to fix them out.

manik23 avatar May 30 '21 04:05 manik23

Sure thing, just make a PR and I can take a look

edfungus avatar May 30 '21 07:05 edfungus

I have fixed some of the MQTT python client's print statements. it's my first and simple contribution to this project. Please review it.

Best Regards Manik Mahajan

On Sun, May 30, 2021 at 1:20 PM Edmund Fung @.***> wrote:

Sure thing, just make a PR and I can take a look

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/edfungus/Crouton/issues/49#issuecomment-850958105, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBK3KK3HPSCTOJUKGCJTODTQHU4PANCNFSM45Y5PTQA .

manik23 avatar Jun 05 '21 16:06 manik23