SuperTinyIcons icon indicating copy to clipboard operation
SuperTinyIcons copied to clipboard

Quality problems with the new Google icons

Open logiclrd opened this issue 4 years ago • 4 comments

A PR with new Google icons was recently merged. I was concerned about (albeit minor) quality issues during review of the PR, but wasn't able to give it my full attention. I've gone and taken a close look at the Google icons after the fact, and have found some quality issues:

google.svg: image

google_calendar.svg: image

google_play.svg: image image

gmail.svg: image

There's one more, but I'm not 100% certain of it:

google_plus.svg: image

I've had a hard time tracking down official Google+ logos, no doubt because of how long it has been defunct. Most seem to be a straight 90 degree corner there. Some are rounded, but the rounding is as if the G were carved out of a perfect circle, which is also not reflected in google_plus.svg here. It looks like the final part of the curve leading up to the 90 degree turn got turned into a straight line segment somehow.

logiclrd avatar Nov 09 '20 08:11 logiclrd

I think ignore the G+ as it is defunct. But very happy for you to correct the new Google ones.

edent avatar Nov 09 '20 08:11 edent

I'll take a look when I have the time :-)

logiclrd avatar Nov 09 '20 08:11 logiclrd

Hello, I was the one who made the PR in question, I tried to reduce these problems after you pointed them but I didn't see I left so much, thank you for your review.

Could you tell me which viewer you're using please because I didn't get most of the issues you mentioned then.

Since you seem to be ready to do a PR for these, I'll give you some informations on the icons modified by the PR :

Gmail : The red DO go behind the yellow, that's the solution I found to the rendering quirk making white lines between two lines with exact same coordinates (like the issue you found in google_calendar between green and red), but It is not visible in the renderers I use to qualiity check what I do (Firefox 83.0b9, Inkscape 0.92.3 (2405546, 2018-03-11) and Eye of gnome 3.28.1) image I used this technique in all of them, for exemple in gmail : red goes behind dark red and yellow, blue goes behind dark red, green goes behind yellow

Google Calendar : Sorry for the 1, I'm really bad with characters and didn't see the little bump :pray: For the green/red white line, it's here because I didn't use the technique mentioned above because I couldn't find a way to do it without adding a big lump of bytes.

jonatjano avatar Nov 09 '20 10:11 jonatjano

I am just using Google Chrome, pointed directly at the .svg files. In the case of the red peeking out from behind the yellow, it only shows up when it's not zoomed in -- in a close-up like you posted, it does render perfectly, but when it's a regular sized view, something about the way it renders means that a hint of red gets mixed in along the yellow's edge.

logiclrd avatar Nov 09 '20 15:11 logiclrd