SuperTinyIcons icon indicating copy to clipboard operation
SuperTinyIcons copied to clipboard

Add WorkOS

Open DragonSenseiGuy opened this issue 2 months ago • 5 comments

Thank you for your contribution! Before sending this Pull Request, please confirm the following:

  • [x] I have read the contributing guidelines
  • [x] I have run python check.py and received a ✅
  • [x] The icon's size is under 1,024 Bytes
  • [x] The layout of the SVG looks like this including newlines
<svg xmlns="http://www.w3.org/2000/svg"
aria-label="..." role="img"
viewBox="0 0 512 512"><path
d="m0 0H512V512H0"
fill="#fff"/> ... </svg>

If you have done the above, please send the Pull Request.

Please also add the hacktober tag. Also I would appreciate a fast response as hacktober is ending. Thanks for understanding!

DragonSenseiGuy avatar Oct 30 '25 02:10 DragonSenseiGuy

(Moved my comments here) This is very close but does not match the requested file style and does not fit fully in the guideline green circle. Please double check the guidelines.

You might be able to reduce the file size by using a clone of one path and rotating by 180 degrees (<use href="#a" transform="rotate(180, 256, 256)/>)

Also the photoshop.svg file should not be in this PR. Please try again!

jmb avatar Oct 30 '25 11:10 jmb

Also the photoshop.svg file should not be in this PR. Please try again!

Seems to be an accident, though I still don't know why the python check.py kept changing the file. I remember it changing the file but, I forgot to not git add it. Thanks!

DragonSenseiGuy avatar Oct 30 '25 11:10 DragonSenseiGuy

@DragonSenseiGuy you need to read https://github.com/edent/SuperTinyIcons/blob/master/CONTRIBUTING.md#shrinking

You ticked the box saying that you had read it.

The reason for that is to help you understand what we require for this project.

edent avatar Oct 30 '25 13:10 edent

You ticked the box saying that you had read it.

Yes I used them to optimize it before, but I did not realize that after changing a few things using an SVG editor It reset them. I will make the changes. Thank you.

DragonSenseiGuy avatar Oct 30 '25 13:10 DragonSenseiGuy

I've taken a look and it is not in the correct place as it doesn't fit in the green circle area as per the guideline.svg

image

Once you have adjusted the first path to be in the right place, then giving it an id="a" and doing the use that I mentioned will help reduce the file size. I recommend using https://yqnn.github.io/svg-path-editor/ to play with the rounding and optimise the path - you only need to paste in the d value from a path element.

Also, the layout of the file still doesn't match the guidelines given (it even mentions that in the PR template right at the top here!)

jmb avatar Oct 30 '25 14:10 jmb