Open-Source-Shakespeare icon indicating copy to clipboard operation
Open-Source-Shakespeare copied to clipboard

Fix the Plays some characters are in

Open prig9951 opened this issue 6 years ago • 1 comments

Hi Terence,

I made a pull request for the fixes I in the character table as per the email I sent you.

email was I discovered a total of 5 incorrect works field in the character table these were

blunt is henry4p1,henry4p2 Should be henry4p1
EdmundMortimer is henry6p1,henry6p3 Should be henry6p1
falstaff is henry4p1,henry4p2,henry5,merrywives Should be henry4p1,henry4p2,merrywives
SirWilliamStanley is henry6p3,richard3 Should be richard3
westmoreland is henry4p1,henry4p2,henry5,henry6p3 Should be henry4p1,henry4p2,henry5

I found this out by creating these views

Create or Replace view charidworkid as (select distinct CharID, WorkID from Paragraphs order by CharID, WorkID);

Create or Replace view charidworkidgroup as (select CharID, REGEXP_REPLACE(REPLACE(GROUP_CONCAT(WorkID,','),',,',','),',$','') Works from charidworkid group by CharID);

and then running the following script

select c.CharID , c.Works, g.Works, IF(c.Works = g.Works,'Match','Might Match') 'Match' , IF(LENGTH(c.Works) = LENGTH(g.Works),'Match Length','NO Match') 'LengthMatch' from Characters c, charidworkidgroup g where c.CharID = g.CharID and c.CharID <> 'xxx' order by IF(c.Works = g.Works,'Match','No Match'), IF(LENGTH(c.Works) = LENGTH(g.Works),'Match Length','NO Match');

prig9951 avatar Feb 07 '20 06:02 prig9951

Thanks for this pull request. A few points to note...

Blunt - he does appear in Henry IV pt2

Enter PRINCE JOHN OF LANCASTER, WESTMORELAND, BLUNT, and others

and then

Exeunt BLUNT and others with COLEVILE He literally enters, exits, then is killed offstage.

Edmund Mortimer is in Henry VI p3

Exeunt YORK, EDWARD, EDMUND, GEORGE, RICHARD, WARWICK, NORFOLK, MONTAGUE, their Soldiers, and Attendants

Yup. He leaves the stage - having never appeared.

Falstaff is mentioned extensively in Henry V - see https://en.wikipedia.org/wiki/Falstaff#Henry_V

Sir William Stanley enters and is spoken about in Henry 6 pt3

SCENE V. A park near Middleham Castle In Yorkshire. Enter GLOUCESTER, HASTINGS, and STANLEY GLOUCESTER Now, my Lord Hastings and Sir William Stanley,

Westmoreland does appear in H6 pt3 as

('henry6p3', 643710, 67, 'EarlWestmoreland-h63', 'What, shall we suffer this? let''s pluck him down:\nMy heart for anger burns; I cannot brook it.', 1, 1),

So, I think this PR needs a few changes. It should just be:

  • Remove Falstaff from Henry V
  • Either remove the duplicate Westmoreland, or merge with the existing one.

edent avatar Feb 07 '20 09:02 edent