react-tap-event throws an error and prevents development from running

[brianyang]

importing react-tap-event throws an error and prevents the app from running

[brianyang]

@eddyystop this error doesn't seem related. do you know what this means?

npm ERR! notarget No compatible version found: babel-types@^6.19.0

[eddyystop]

babel-types: This module contains methods for building ASTs manually and for checking the types of AST nodes.

It appears to be an error in syntactic analysis of the ES6. What changes have you made to the src or package.json?

On Wed, Nov 16, 2016 at 12:12 PM, Brian Yang [email protected] wrote:

@eddyystop https://github.com/eddyystop this error doesn't seem related. do you know what this means?

npm ERR! notarget No compatible version found: babel-types@^6.19.0

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/eddyystop/feathers-starter-react-redux-login-roles/pull/2#issuecomment-261008212, or mute the thread https://github.com/notifications/unsubscribe-auth/ABezn0wGZlv6CojCpyNTexWOIibyouDUks5q-zligaJpZM4K0Exf .

[eddyystop]

Out of interest, what version of react and react-tap-event-plugin are you using? I'm wondering if its react v15.4 which was released today.

[brianyang]

I haven't made any changes to the src or package.json. on React v15.4.0

Missing imports with React 15.4.0 https://github.com/zilverline/react-tap-event-plugin/issues/85#issuecomment-261040969

updated package json to use v2 🛩

[eddyystop]

I copied the repo and ran npm install. It seems to run fine with React 15.3.1 running on a Ubuntu VM.

The React 15.4 release posting (https://facebook.github.io/react/blog/2016/11/16/react-v15.4.0.html) mentions:

"If you only use the official and documented React APIs you won't need to change anything in your application.

However, there is a possibility that you imported private APIs from react/lib/*, or that a package you rely on might use them. We would like to remind you that this was never supported, and that your apps should not rely on internal APIs."

react-tap-event-plugin does use internal APIs. Its a useful and popular repo, so I would hope it's updated.

I'll wait about a week to see what happens before merginging your PR.

Thanks for the catch!

p.s. Any news on that Babel issue?

[brianyang]

in this commit the author of react-tap-event-plugin has made changes to support v15.4

https://github.com/zilverline/react-tap-event-plugin/commit/cdd779fe75d5927b630fd202ae1a44b0d592f25a

:arrow_up: react-tap-event-plugin to v2.0. No more babel issue but the CI :construction_worker: fails. Looks like linting :rotating_light: issues:

> [email protected] eslint /home/travis/build/eddyystop/feathers-starter-react-redux-login-roles
> eslint client/. common/. config/. server/. test/. --ext .js,.jsx
The react/require-extension rule is deprecated. Please use the import/extensions rule from eslint-plugin-import instead.
/home/travis/build/eddyystop/feathers-starter-react-redux-login-roles/client/screens/Users/components/UsersNavBar.js
  129:3  error  Expected indentation of 6 spaces but found 2  indent
/home/travis/build/eddyystop/feathers-starter-react-redux-login-roles/client/screens/Users/UserRolesChange/Form.js
  20:7  error  Expected indentation of 8 space characters but found 6  react/jsx-indent
/home/travis/build/eddyystop/feathers-starter-react-redux-login-roles/server/helpers/emails.js
  20:73  error  Unnecessary escape character: \'  no-useless-escape
✖ 3 problems (3 errors, 0 warnings)

[eddyystop]

Info, thanks!

I'll update the react-tap-event-plugin version at the same time react is brought up to v15.4.0.

[bekher]

I was able to resolve these issues by upgrading react-tap-event-plugin to 2.0.1 and material-ui to 0.16.3.

[matthabermehl]

Attempting to fix in https://github.com/eddyystop/feathers-starter-react-redux-login-roles/pull/28 Will check to see if tests pass (they pass locally)

[eddyystop]

Thanks Matt!

On Thu, Feb 9, 2017 at 12:09 PM, Matt Habermehl [email protected] wrote:

Attempting to fix #28 https://github.com/eddyystop/feathers-starter-react-redux-login-roles/pull/28

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/eddyystop/feathers-starter-react-redux-login-roles/pull/2#issuecomment-278706725, or mute the thread https://github.com/notifications/unsubscribe-auth/ABezn5X4zEZgakEimCUAOzGTHTZT-dfaks5ra0hAgaJpZM4K0Exf .