cpp-coveralls icon indicating copy to clipboard operation
cpp-coveralls copied to clipboard

collect_non_report_files: use 0 instead of None for no coverage

Open blueyed opened this issue 8 years ago • 4 comments

Otherwise it shows up as 100% covered in Coveralls.

blueyed avatar Aug 16 '17 12:08 blueyed

Not verified if this fixes it really, but it is likely.

blueyed avatar Aug 16 '17 12:08 blueyed

Not verified?

You should be able to test this yourself before we merge it.

chrisosaurus avatar Jun 15 '18 01:06 chrisosaurus

The json format for coveralls.io uses both 'null' and '0' http://docs.coveralls.io/api-reference

0 if the line is not covered by the test suite.
null to indicate the line is not relevant to code coverage (it may be whitespace or a comment).

can you please indicate which files you had which were incorrectly showing up as 100% coverage?

chrisosaurus avatar Jul 08 '18 05:07 chrisosaurus

@mkfifo If I remeber this was with awesomeWM/awesome, but it also ~1 year old.

IIRC it is like documented: 0 means not covered and None means not relevant for coverage. And from looking at the code quickly it looks like the files there are not covered (it skips non-sourced files etc).

Anyway, I am using codecov.io and Python mainly anywany - feel free to close it.

blueyed avatar Jul 08 '18 14:07 blueyed