circleci-queue icon indicating copy to clipboard operation
circleci-queue copied to clipboard

Published 20 hours ago • verified publisher icon eddiewebb

Ignore 404 in `fetch_active_workflows` [semver:minor]

Open davet1985 opened this issue 3 years ago • 4 comments

Checklist

  • [x] All new jobs, commands, executors, parameters have descriptions
  • [x] Examples have been added for any significant new features
  • [x] README has been updated, if necessary

Motivation, issues

Attempts to fix https://github.com/eddiewebb/circleci-queue/issues/79 by better handling a 404 from the CircleCI API when getting workflows.

Description

davet1985 avatar Apr 27 '22 13:04 davet1985

@eddiewebb would be great to have this merged

asselinpaul avatar Apr 27 '22 17:04 asselinpaul

To move forward with this we need to make it optional, as a parameter to ignore missing workflow data, or figure out why IDs declared by active jobs don't exist.

ignore-missing-worflows or similar with a default behavior to expect all data, and an override to allow missing data to just be an notice and not a failure.

eddiewebb avatar Apr 28 '22 10:04 eddiewebb

@eddiewebb given your recent findings, do we still want this to be merged, maybe as a workaround at least? Does it depend on adding a parameter to toggle this feature?

asfaltboy avatar Apr 28 '22 19:04 asfaltboy

@asfaltboy, @davet1985, @asselinpaul - I closed #79 based on a fix and recent API changes.

If we want to push for this PR anyway I would want to gate it behind a parameter like ignore-404 with a default to NOT ignore them as they could actually be 403/bad token errors.

eddiewebb avatar May 04 '22 18:05 eddiewebb

I am closing for now. If there is interwst to re-submit feature behind a flag please feel free to re-open or reference in new PR.

eddiewebb avatar Oct 29 '22 11:10 eddiewebb