react-native-boundary icon indicating copy to clipboard operation
react-native-boundary copied to clipboard

Fixes for iOS and fully working with Android (including Oreo, Pie, Q)

Open woffu opened this issue 4 years ago • 7 comments

  • IOS, We fixed the issue with the RNBoundary.podspec
  • Android, We fixed the issue with startService when the app is in background and correctly handling it using a startForegroundService with a binded notification.

woffu avatar Aug 20 '19 10:08 woffu

Any news on the delivery date for the fix?

gate8team avatar Aug 28 '19 08:08 gate8team

When do you think this fix will be merged?

AlekseiSkrebkov avatar Sep 09 '19 20:09 AlekseiSkrebkov

cc @eddieowens

johnou avatar Sep 09 '19 20:09 johnou

@eddieowens is this going to be merged or should I use @woffu's fork?

grubstarstar avatar Dec 15 '19 02:12 grubstarstar

Any news if this will be merged?

mathiasmoeller avatar Feb 19 '20 14:02 mathiasmoeller

@woffu Your fixes seem to work! Great stuff. But could you maybe give me an example on how to handle events when the app was killed? I add some boundaries, I attach EXIT and ENTER listeners. Everything works while the app is in foreground or in background. When I kill the app and leave the boundary, I can see in the React Native Debugger that the App is triggered. The console logs an onExit event from the boundary index.js file. But the listeners that I attached are not called. I guess the reason is that they were destroyed when the app was killed. I tried to attach the listeners again on App start in my index.js file (I guess that is the earliest time I can do something) but it did not work. Since you worked with this feature could you maybe give me an example on how you listened to ENTER/EXIT events when the app was killed? Help is very much appreciated!

mathiasmoeller avatar Feb 19 '20 14:02 mathiasmoeller

Hi @woffu , great work, thanks for the PR!

That PR has been open for months and there is no update, I need to do the same fix for iOS (work in the background), I have merged it in my own PR https://github.com/eddieowens/react-native-boundary/pull/56

I wonder if we should start maintaining that project in another github?

cladjules avatar May 10 '20 15:05 cladjules