stargate icon indicating copy to clipboard operation
stargate copied to clipboard

fix: channel id outputs coming due to discord.js v updates

Open krishdevdb opened this issue 3 years ago • 8 comments

Fixes #

Proposed Changes

  • Fixes the problem of id mentions added in the new discord.js version

Screenshots

krishdevdb avatar Jul 14 '21 08:07 krishdevdb

This will now break for the other version. We should lock down the version to be consistent and make sure we lock it down to the latest version

eddiejaoude avatar Jul 14 '21 08:07 eddiejaoude

This will now break for the other version. We should lock down the version to be consistent and make sure we lock it down to the latest version

I mean we can upgrade to latest on both platforms

ghost avatar Jul 14 '21 08:07 ghost

We should not need to upgrade on both not even sure how we could do that, we should upgrade in the repo and make sure that everywhere is using the package.lock to be consistent

eddiejaoude avatar Jul 14 '21 08:07 eddiejaoude

Do we really need to mention them again? I think 2 mentions for a simple test command, is a bit too much

Vyvy-vi avatar Jul 14 '21 12:07 Vyvy-vi

Do we really need to mention them again? I think 2 mentions for a simple test command, is a bit too much

We don't exactly use the mention again, we keep the mention. If we don't want to keep the mention I can introduce changes?

ghost avatar Jul 14 '21 12:07 ghost

Stale pull request message

github-actions[bot] avatar Sep 13 '21 01:09 github-actions[bot]

What is the update on this? What are the requirements exactly?

adityaraute avatar Oct 19 '21 07:10 adityaraute

I can't remember the original discussion. I might mark this repo as archive for the moment

eddiejaoude avatar Oct 19 '21 08:10 eddiejaoude