edbee-lib icon indicating copy to clipboard operation
edbee-lib copied to clipboard

config.h and confugure (and possibly config.h.in) should NOT be tracked / included by

Open SlySven opened this issue 7 years ago • 2 comments

These files are both ones that are/can be generated at build time and their contents will thus vary depending on the target platform - therefore tracking them will throw up issues when they are regenerated and do not then match the originals included in the repository. This is noticeable after the fix provided by #48 as that now (correctly) calls the Onigmo configure file and the resulting config.h will be build target dependent and if the git repository copy is from a different bitness platform compared to that where the library is being used it will get changed (on *nix at least) which will then show up as a modification tracked by Git when it should be .gitignore d instead (IMHO).

SlySven avatar Aug 25 '17 22:08 SlySven

I totally agree with this... We need to fix it, so it also compiles (on Windows) without this generated config.h

gamecreature avatar Aug 28 '17 05:08 gamecreature

This is pretty tricky, because the config.h file is required for building on windows. (And isn't generated there) I cannot simply gitignore it, because the windows installation will not build anymore..

gamecreature avatar Aug 28 '17 13:08 gamecreature