kubler icon indicating copy to clipboard operation
kubler copied to clipboard

Fix dl_name with latest

Open berney opened this issue 3 years ago • 1 comments

Function download_portage_snapshot() has a subtle bug when $PORTAGE_DATE equals latest (the default), it sets dl_name to be $_TODAY. It should do this for every file, but it always sets dl_name to portage_file, so each loop dl_name will be the same, and the "already download" check will pass, skipping the other loops, and the final check at the end.

With this fix, dl_name is set correctly based off file, similar to the line 464. This causes all 3 files to be downloaded, and the final check at the end to not be skipped.

berney avatar Sep 16 '22 16:09 berney

P.S. I've messaged you on Discord.

berney avatar Sep 16 '22 16:09 berney

Thanks for the PR, nice catch!

edannenberg avatar Oct 27 '22 11:10 edannenberg