kubler icon indicating copy to clipboard operation
kubler copied to clipboard

kubler build interactive behaviour difference: continues on errors in configure_bob()

Open berney opened this issue 3 years ago • 1 comments

Currently for me the kubler/bob-musl image is failing to build.

In the builder/bob-musl/build.sh configure_bob() one of the steps is failing (I opened a separate issue #214 for this).

If I run kubler build -i kubler/bob-musl and then kubler-build-root the same error occurs, but instead of stopping at the failed command the build continues to execute all the commands in the configure_bob() function.

I think the behaviour in interactive mode should stop on the failed command like in non-interactive mode. Otherwise the terminal can have a lot of output and the build can look successful (it may even be successful, if the error didn't impact it).

berney avatar Sep 11 '22 12:09 berney

This might be a bit of an edge case for build containers in interactive mode. Interactive mode is not running Bash in super strict mode as that might also exit the build container completely on errors, which is most likely not what you want. Not sure this can be resolved easily.

edannenberg avatar Oct 27 '22 13:10 edannenberg