penis.js icon indicating copy to clipboard operation
penis.js copied to clipboard

Missing getters

Open fredRos opened this issue 9 years ago • 4 comments

Thanks for creating this awesome package! I wanted to use it right away but quickly ran into problems. Seems like this project is still on the rise so I wanted to add suggestions for improvement:

  1. If there is setHead how come there is no getHead? To many users, this is a very important method. Please consider implementing it, but only after thorough testing.
  2. Maybe I was missing the point of the package but why is there no penis.getLength? The documentation states that this is about comparing variables and how can you do a penis.js comparison without the length? Seriously, you should go back and rub your head, then upload a new version.

fredRos avatar Mar 27 '15 13:03 fredRos

Good idea man! But for the penis.getLength(), what should be the return value? Also, do you think getSize() would be a better name?

edankwan avatar Mar 27 '15 15:03 edankwan

I've heard that getSize() doesn't matter.

pappacena avatar Jan 17 '17 20:01 pappacena

Yes, it does! It is only told by people who have uglyfied packages.

For values which can be compared numerically, getSize() could be their absolute difference. Visualise the balls and head at points on a number line.

rheber avatar Sep 13 '18 11:09 rheber