Eduard S.

> I believe the overflow in `MulAddWords` is just intended to work as a flag that indicates wethere there was overflow or not. It doesn't even compute what would be...

> @han0110, @ed255 , @miha-stopar, does my description here match what you guys have in mind? Your description matches exactly the way I have in mind :) The main points...

Specs PR for this https://github.com/privacy-scaling-explorations/zkevm-specs/pull/236

Now that the prover is no longer in this repo after https://github.com/privacy-scaling-explorations/zkevm-circuits/pull/714 maybe this issue should be transferred to the `zkevm-chain` repository?

@pinkiebell your analysis of the part that is not economically viable is the calculation of the random linear combination with the `raw_public_inputs` right? Which requires an `MULMOD + ADDMOD` for...

A big part of this task is already complete via https://github.com/privacy-scaling-explorations/zkevm-circuits/pull/878. The missing bits are: - [x] https://github.com/privacy-scaling-explorations/zkevm-circuits/issues/966 - [x] https://github.com/privacy-scaling-explorations/zkevm-circuits/issues/967 - [x] https://github.com/privacy-scaling-explorations/zkevm-circuits/issues/968 - [ ] Get all tests...

Update: currently the keccak circuit is failing with the real prover but not the mock prover. The latest mock prover has strict checks to verify correctness of using the Challange...

We had a meeting with Han, David and me to discuss this. Here are the notes: https://hackmd.io/0Vj4K1_BR6GX7UV5HSaWsg?view These were the conclusions: - We need to remove the blinding factors to...

Let's keep this issue to track the sound implementation of the Public Inputs Circuit. Depends on: - https://github.com/privacy-scaling-explorations/halo2/issues/105

> Question. Do you know if #1345 fixes this issue? > cc @davidnevadoc @hero78119 It does! Previously we needed a random challange to be used to calculate the circuit public...